Add a few tests for writing vlen string datasets #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
=======================================
Coverage 84.48% 84.48%
=======================================
Files 17 17
Lines 2037 2037
=======================================
Hits 1721 1721
Misses 316 316Continue to review full report at Codecov.
|
takluyver
reviewed
Oct 24, 2019
| """ | ||
| dt = h5py.string_dtype('utf-8') | ||
| ds = self.f.create_dataset('x', (100,), dtype=dt) | ||
| ds[0] = None |
There was a problem hiding this comment.
Yikes, that works? I suspect we may change that for 3.0. +1 to testing things as they stand, though.
There was a problem hiding this comment.
Yes.... removing such things would simplify the conversion code.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few tests of writing (and reading) vlen string datasets in some specific cases.
I felt uncomfortable helping with PR #1406 without every case being tested.
This is a small step towards #1405.