Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Want to use H5Pset_obj_track_times #225

Closed
andrewcollette opened this issue Dec 27, 2012 · 9 comments
Closed

Want to use H5Pset_obj_track_times #225

andrewcollette opened this issue Dec 27, 2012 · 9 comments
Labels
enhancement
Milestone
2.2.0

Comments

@andrewcollette
Copy link
Contributor

Original author: ian.hin...@gmail.com (November 25, 2011 15:53:58)

For storing HDF5 files in version control, it is very useful to have them be the same each time they are generated. For this reason, I would like access to the H5Pset_obj_track_times API so that I can disable dataset timestamps.

Original issue: http://code.google.com/p/h5py/issues/detail?id=225
@andrewcollette
Copy link
Contributor Author

From tcasw...@gmail.com on January 08, 2012 07:56:01
I have attached a patch that adds this to the low level interface.

@andrewcollette
Copy link
Contributor Author

From tcasw...@gmail.com on January 08, 2012 18:12:18
The changes are also in the issue225 branch in https://code.google.com/r/tcaswell-h5pydev/ .

Sorry that the heads are a bit of a mess, I was trying to use hg like git.

@andrewcollette
Copy link
Contributor Author

From tcasw...@gmail.com on January 08, 2012 18:49:47
and unit tests.

@andrewcollette
Copy link
Contributor Author

From barry.wa...@gmail.com on February 29, 2012 13:57:23
I have tested these patches with the latest mercurial version and can confirm that they work fine for me. I also find the attached patch for the high-level interface convenient.

@wvangeit
Copy link

Are there any plans to merge this into the master ? I think this is a very useful feature.

@ddale
Copy link
Contributor

ddale commented Feb 18, 2013

Yes, BUT. h5py has progressed to the point that the patches will have to be substantially modified in order to merge. I tried to gather the patches together into a git branch a couple weeks back, but I got stuck and haven't had a chance to try again.

@wvangeit
Copy link

Do you mean that the logic of the patches has to be significantly modified ? At the moment, I've manually applied the patches to the latest revision of the git repo, and things 'seem' to work, but of course maybe you saw some problems I missed. If you want I can post these new patches, only still have to add the unit tests.

@ddale
Copy link
Contributor

ddale commented Feb 18, 2013

It would be great if you could push these changes up to github and file a pull request. Then we could continue the discussion in code review.

tacaswell added a commit to tacaswell/h5py that referenced this issue Feb 20, 2013
@tacaswell
mereged in old patches for issue h5py#225
e39e80e
tacaswell pushed a commit to tacaswell/h5py that referenced this issue Feb 20, 2013
@barrywardell @tacaswell
This is a path submitted by barry.wardell@gmail.com to the google cod…
b6635d1 
…e site on issue h5py#225 with the following message:

'I have tested these patches with the latest mercurial version and can confirm that they work fine for me.
I also find the attached patch for the high-level interface convenient.'

Shoved into git by Thomas Caswell <tcaswell@gmail.com>
tacaswell added a commit to tacaswell/h5py that referenced this issue Apr 2, 2013
@tacaswell
mereged in old patches for issue h5py#225
4ae3868
tacaswell pushed a commit to tacaswell/h5py that referenced this issue Apr 2, 2013
@barrywardell @tacaswell
This is a path submitted by barry.wardell@gmail.com to the google cod…
7f055b6 
…e site on issue h5py#225 with the following message:

'I have tested these patches with the latest mercurial version and can confirm that they work fine for me.
I also find the attached patch for the high-level interface convenient.'

Shoved into git by Thomas Caswell <tcaswell@gmail.com>
@andrewcollette
Copy link
Contributor Author

Fix merged into master via #271.

@ebenolson ebenolson mentioned this issue Jan 5, 2015
Merged
@LTLA LTLA mentioned this issue Feb 6, 2020
Closed
@ivirshup ivirshup mentioned this issue May 20, 2020
Closed
@takluyver takluyver mentioned this issue Jul 5, 2021
Closed
@takluyver takluyver mentioned this issue Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@ddale @wvangeit @andrewcollette