Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST,CI: Specify coverage location as default #1160

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

aragilar
Copy link
Member

Coverage looks by default at .coverage, but due to cd'ing to .tox, the
output file is written to a different location than the default.
Specifying the base dir in the associated envvar when testing fixes
this.

This is why even though codecov appears to be set up, no data is being sent.

Coverage looks by default at .coverage, but due to cd'ing to .tox, the
output file is written to a different location than the default.
Specifying the base dir in the associated envvar when testing fixes
this.
@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@50b03c3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1160   +/-   ##
=========================================
  Coverage          ?   83.73%           
=========================================
  Files             ?       18           
  Lines             ?     2146           
  Branches          ?        0           
=========================================
  Hits              ?     1797           
  Misses            ?      349           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b03c3...108e91d. Read the comment docs.

@takluyver takluyver added this to the 2.10 milestone Jan 10, 2019
@takluyver takluyver merged commit 7e4687f into h5py:master Jan 10, 2019
@aragilar aragilar deleted the fix-coverage branch October 6, 2019 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants