Remove deprecated File.fid attribute #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File.id works instead. This has been described as "backwards compatibility" in the docstring since 2.0, and issued deprecation warnings since 2.9 (h5pygh-1047).
Codecov Report
@@ Coverage Diff @@
## master #1378 +/- ##
==========================================
- Coverage 84.24% 84.21% -0.04%
==========================================
Files 17 17
Lines 2056 2052 -4
==========================================
- Hits 1732 1728 -4
Misses 324 324
Continue to review full report at Codecov.
|
|
The only failure is a very small coverage change, and given we're had this deprecated forever, I'm going to merge this. Thanks @takluyver! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File.idworks instead. This has been described as "backwards compatibility" in the docstring since 2.0, and issued deprecation warnings since 2.9 (gh-1047).