Add validateField() and use it in isFieldValid()
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlbyk
commented
Oct 17, 2023
Comment on lines
-970
to
-974
| let isDropdown = input.tagName.toLowerCase() === 'select'; | ||
| let validateEvent = input.dataset.valEvent; | ||
| if (isDropdown) { | ||
| input.addEventListener('change', cb); | ||
| } else if (validateEvent) { |
There was a problem hiding this comment.
While I'm in the area I noticed the data-val-event override is being ignored for <select>. The attribute now takes precedence over the default change event.
|
This is live on NPM! https://www.npmjs.com/package/aspnet-client-validation |
|
This may need a separate issue but I believe the change from this isn't reflected on README documentation yet and will likely cause some confusion around the pre-validation when used in updated release. Also it would be worth mentioning debounce functionality in that area for future users. Thank you again for this work 🙌 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected
isFieldValid()behavior is to check a single field, not the whole form. This is technically a breaking change, but the workaround is easy: callvalidateForm()(orisValid()) if you want to validate the whole form.isValid()callsvalidateForm()unlessprevalidate: falseisFieldValid()callsvalidateField()unlessprevalidate: falseIn both cases I tried to document that the synchronous return value isn't necessarily accurate if there's async validation.
Would welcome a demo from someone showing off how this can be used.