Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hab/mac] Fix mac-build.sh for new install.sh logic. #1454

Merged
merged 1 commit into from
Nov 4, 2016

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Nov 4, 2016

This fix makes our release process work again.

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
@fnichol fnichol added the Bug label Nov 4, 2016
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@reset
Copy link
Collaborator

reset commented Nov 4, 2016

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 658b2b0 into master Nov 4, 2016
@thesentinels thesentinels deleted the fnichol/fix-mac-build branch November 4, 2016 23:47
@fnichol
Copy link
Collaborator Author

fnichol commented Nov 4, 2016

I forgot to push this after the 0.12.0 release, and then almost forgot again. Tech debt, paid off!

gif-keyboard-4162724740119326592

@eeyun eeyun added C-bug and removed Bug labels Jun 6, 2017
@christophermaier christophermaier added Type: Bug Issues that describe broken functionality and removed C-bug labels Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that describe broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants