Reduce allocations when working with ServiceGroup #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServiceGroup now contains a single string allocation and three functions to access parts of the service group. This allows us to greatly reduce the amount of string allocations when attempting to comopare the full representation of a service group instead of it's components. I also did a bit of work refactoring the public API of the key generation functions to make them easier to use Signed-off-by: Jamie Winsor <jamie@vialstudios.com>
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
mwrock
reviewed
Jan 30, 2017
| Err(format!("SERVICE_GROUP: '{}' is invalid", &val)) | ||
| match ServiceGroup::validate(&val) { | ||
| Ok(()) => Ok(()), | ||
| Err(err) => Err(err.to_string()), | ||
| } |
mwrock
reviewed
Jan 30, 2017
| pub group: String, | ||
| pub organization: Option<String>, | ||
| } | ||
| pub struct ServiceGroup(pub String); | ||
| } |
There was a problem hiding this comment.
Oh. I see you are using a Jamie style struct!
|
This looks great! Very nice not to have to |
mwrock
approved these changes
Jan 30, 2017
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
christophermaier
added
Focus:Supervisor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceGroup now contains a single string allocation and three
functions to access parts of the service group. This allows us
to greatly reduce the amount of string allocations when attempting
to comopare the full representation of a service group instead of
it's components.
I also did a bit of work refactoring the public API of the key
generation functions to make them easier to use