Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit current Cargo.lock file after building entire project. #1692

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Jan 31, 2017

After running a full build from current master on a clean repo checkout, this small lock file diff was the result, most likely due to refactoring.

After running a full build from current master on a clean repo checkout,
this small lockfile diff was the result, most likely due to refactoring.

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
@fnichol fnichol added the Chore label Jan 31, 2017
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@mwrock
Copy link
Contributor

mwrock commented Jan 31, 2017

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 9f1e29a into master Jan 31, 2017
@thesentinels thesentinels deleted the fnichol/dirty-lockfile branch January 31, 2017 16:34
@eeyun eeyun added C-chore and removed Chore labels Jun 6, 2017
@christophermaier christophermaier added Type: Chore Issues for general code and infrastructure maintenance and removed C-chore labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Chore Issues for general code and infrastructure maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants