[sup] Install a package only if missing for start & load.
#3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue in `hab-sup start` and `hab-sup load` where the Supervisor was unconditionally attempting to install a package saving the Service spec. Without an explicit update strategy, the Supervisor should find an load the latest version of an installed package on disk. Otherwise, newer releases of a package will be download and installed whenever a new candidate is present in the Builder API. Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
|
@fnichol Good catch! @thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
|
@fnichol should we patch release this? |
|
@reset Yes: without this any Docker images would install new versions on boot, and services in production would likely upgrade themselves starting back up from a |
christophermaier
added
Focus:Supervisor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue in
hab-sup startandhab-sup loadwhere theSupervisor was unconditionally attempting to install a package saving
the Service spec. Without an explicit update strategy, the Supervisor
should find an load the latest version of an installed package on disk.
Otherwise, newer releases of a package will be download and installed
whenever a new candidate is present in the Builder API.
Signed-off-by: Fletcher Nichol fnichol@nichol.ca