-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pkg_svc_run behavior in powershell plans #4486
Conversation
Signed-off-by: mwrock <matt@mattwrock.com>
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -1117,13 +1117,15 @@ function Invoke-DefaultBuildService { | |||
Write-BuildLine "Using run hook $PLAN_CONTEXT/hooks/run" | |||
} | |||
else { | |||
if ($pkg_svc_run -ne "" -and (Test-Path $pkg_svc_run)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right, then we can add flags, args, etc.
`$cmd = @" | ||
$pkg_svc_run | ||
"`@ | ||
Invoke-Expression -Command `$cmd 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
@thesentinels approve |
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
Travis CI has started testing this PR. |
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question: |
This fixes #4479
I have tested this with the aspnet sample:
and it works.
Signed-off-by: mwrock matt@mattwrock.com