adding a --windows option for hab plan init to generate powershell plan #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwrock
requested review from
christophermaier,
cnunciato,
fnichol,
mgamini and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
cnunciato
reviewed
Jan 31, 2018
| PS C:\\> hab plan init --windows yourplan | ||
| ``` | ||
|
|
||
| this generates a `plan.ps1` with propper Powershell variables, arrays, hashtables and functions. |
cnunciato
reviewed
Jan 31, 2018
| # See full docs at https://www.habitat.sh/docs/reference/plan-syntax/ | ||
|
|
||
| # Required. | ||
| # Sets the name of the package. This will be used in along with `$pkg_origin`, |
There was a problem hiding this comment.
Should this be used along with? (And if so, probably without the comma at the end of this line.)
cnunciato
approved these changes
Jan 31, 2018
Signed-off-by: mwrock <matt@mattwrock.com>
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need this for the powershell based tutorial. Fixes #4527
Signed-off-by: mwrock matt@mattwrock.com