Make logging around user.toml changes more specific #5713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophermaier
requested review from
baumanj,
fnichol,
raskchanky and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
raskchanky
approved these changes
Oct 5, 2018
|
|
Previously, no indication was given as to *why* a service was restarting here. Additionally, the service doesn't necessarily have to restart; that will only if the `user.toml` changes result in any changes to templated files. Signed-off-by: Christopher Maier <cmaier@chef.io>
christophermaier
force-pushed
the
cm/be-more-specific
branch
from
b067252
to
1b3a4b1
Compare
chef-ci
added a commit
that referenced
this pull request
Oct 5, 2018
Obvious fix; these changes are the result of automation not creative thinking.
christophermaier
added
Type:Breaking Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, no indication was given as to why a service was
restarting here. Additionally, the service doesn't necessarily have to
restart; that will only if the
user.tomlchanges result in anychanges to templated files.
Signed-off-by: Christopher Maier cmaier@chef.io