Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
End to end tests: hab-svc-load and hup-does-not-abandon-services #6849
Any reason not to merge back into your PR? All the e2e work is captured in the same issue, and there are some things in my changes that may be useful to the other e2e tests. Also, it'll just be less work for me to merge it as is since my branch was based on yours from the beginning.
If I were to rework and force-push my branch then that could mess yours up. They're not inherently coupled. If your PR has something I (or anyone else) can use, then I'll rebase mine when yours merges.
Some minor tweaks were necessary to the expect file. Notably, replace `pgrep redis-server` with accessing /hab/svc/redis/PID, since there may be other `redis-server`s running locally. Signed-off-by: Jon Bauman <email@example.com>
We discovered #6852 as part of hup-does-not-abandon-services.exp, but that test is more complex. It's preferable to have a simpler, more targeted test as well which makes the nature of the failure (and potential regression) clearer. Signed-off-by: Jon Bauman <firstname.lastname@example.org>