-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make official Docker Hub image build from source #47
Comments
@hacdias ping |
Hey @pataquets! Sorry for just seeing this now. Yes, if you'd like to contribute, feel free to open a PR. It can probably be done through CircleCI and Goreleaser files. Just ping me to make sure I get a notification :) |
Thanks @pataquets. Closed by #48. |
You're welcome @hacdias . Happy to help. 😄 However, I think that the issue can't be closed, yet. In any case, I think we should keep the issue open while discussing it, if you don't mind. |
Makes sense. it seems we're only pushing images on release |
@hacdias Just pinging and also wanted to let you know about GitHub Container Registry alternative for sorting auditable builds. |
By the way, the PR had to be reverted to fix the release pipeline which resulted in failing builds complaining about files not being available. The error happens because goreleaser creates a temp directory with only the Dockerfile and the binary to make an isolated build. In goreleaser docs it says:
We can have another attempt it at but it should be validated that the goreleaser flow works fine. |
Docker Hub allows you to create Automated Builds from source: https://docs.docker.com/docker-hub/builds/
It also allows to create different image tags from git tags & branches.
By making the image build via an AB, you give the resulting image verifiability and auditability. Also, the build is fully automatic. You can have the
latest
image tag build from HEAD and individual image tags from git's release tags.Some people avoid non-verifiable (manually uploaded) images due to security & traceability reasons.
Docker search command clearly displays AB:
The text was updated successfully, but these errors were encountered: