-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSS bugs #68
Comments
Sorry about that! It looks like the Pull Request that added the event card (PR #67) to that page never got merged in. For that sub-task could you make your commit to the |
Looking good! Thanks for adding that vertical configuration, it will certainly make our job a lot easier if we adapt this website for phones. Quick question -- have you tackled the multiline event title/slots issue yet? If you have which PR should I look at? |
I think it's in the |
PR #75 and PR #78 ended up having a lot of merge conflicts, so unfortunately some of your work ended up getting lost in the process. I think I was able to save most of it, but I was still seeing the multi line issue on the Event Card and the vertical sign up form display got lost in the mix as well. If you could take a look at those two things sometime before finals, I'd really appreciate it. Sorry to make you repeat some work, it was totally not your fault! |
A couple of CSS bugs I noticed that we should get fixed:
I'd highly recommend using your browser's responsive design mode to test these bugs on a variety of screen sizes. Don't worry about mobile sizes yet, but please do check smaller laptop screen sizes.
The text was updated successfully, but these errors were encountered: