Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS bugs #68

Closed
4 tasks done
vwinstea opened this issue Feb 14, 2022 · 6 comments · Fixed by #94
Closed
4 tasks done

Fix CSS bugs #68

vwinstea opened this issue Feb 14, 2022 · 6 comments · Fixed by #94
Assignees

Comments

@vwinstea
Copy link
Contributor

vwinstea commented Feb 14, 2022

@vwinstea vwinstea assigned hayahann and adellevo and unassigned adellevo and hayahann Feb 15, 2022
@adellevo
Copy link
Contributor

Event data is somehow not loading for me at all? I pulled on main to get the latest changes too so idk why this is happening
Screen Shot 2022-02-21 at 1 38 37 PM

@adellevo adellevo linked a pull request Feb 21, 2022 that will close this issue
@vwinstea
Copy link
Contributor Author

Sorry about that! It looks like the Pull Request that added the event card (PR #67) to that page never got merged in. For that sub-task could you make your commit to the hannah-add-eventCard branch?

@adellevo
Copy link
Contributor

Yep! Just added the other changes to the hannah-add-eventCard branch. When the browser width hits a certain breakpoint, the layout should look like this: Screen Shot 2022-02-27 at 11 17 44 AM

@vwinstea vwinstea removed a link to a pull request Feb 28, 2022
@vwinstea
Copy link
Contributor Author

Looking good! Thanks for adding that vertical configuration, it will certainly make our job a lot easier if we adapt this website for phones. Quick question -- have you tackled the multiline event title/slots issue yet? If you have which PR should I look at?

@adellevo
Copy link
Contributor

Looking good! Thanks for adding that vertical configuration, it will certainly make our job a lot easier if we adapt this website for phones. Quick question -- have you tackled the multiline event title/slots issue yet? If you have which PR should I look at?

I think it's in the hannah-add-eventCard branch — the vertical configuration also has a minimum size set to make sure the event box never gets to a size where the multiline thing occurs. Users do have to scroll to view the full form though, and idk if that's okay. Lmk if you'd prefer to have it where no one has to scroll!

@vwinstea
Copy link
Contributor Author

vwinstea commented Mar 1, 2022

PR #75 and PR #78 ended up having a lot of merge conflicts, so unfortunately some of your work ended up getting lost in the process. I think I was able to save most of it, but I was still seeing the multi line issue on the Event Card and the vertical sign up form display got lost in the mix as well. If you could take a look at those two things sometime before finals, I'd really appreciate it. Sorry to make you repeat some work, it was totally not your fault!

@adellevo adellevo linked a pull request Mar 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants