RFR: Create login/signup functionality

[josh-byster]

Status:

🚀 Ready

Deploy link

https://phillyreads-oogncirjbb.now.sh

Description

We would like to have working login and register pages integrating with the JWT from the backend. We would also like the page to be styled and easy-to-use.
Related issues: #4

Todos

Screenshots

[XuanLi-Leong]

Here's my first pass! The only thing I didn't review in depth is the Login and Register render code. Thanks for the great work, and for considering lots of different cases and user flows.

[XuanLi-Leong]

Is this supposed to be commented out?

[XuanLi-Leong]

Maybe we should alert "You are registered and logged in!" instead of "logged in"

[XuanLi-Leong]

Although actually, I do wonder whether this message would be seen, if we're doing redirects.

[josh-byster]

You're definitely right - this was for us to mostly be able to visually debug the JWT storage to avoid having to go into DevTools every time. Now that we're redirecting, we can remove, but upon signup, should we display an alert that's like "welcome"?

[XuanLi-Leong]

Ah I see 😄 Maybe for register, we can delay the redirect (using a timeout?). So it would be:

• Make register request
• Receive success response from BE, update cookie w JWT, start timeout of 1sec
• Show a success state message, also mention you will be redirected in 1 second
• Redirect occurs when timeout triggers

[XuanLi-Leong]

Reviewing the render content of Register and Login -- looks good, just change the text of the submit button

[XuanLi-Leong]

Style thing -- in the case of functions that return components, my practice has been to put the function inside render. That is:

render() {
  return (
    <div>
      {this.renderSomePart()}
    </div>
  );
}

[XuanLi-Leong]

Let's do "isDanger" instead of "isRed" -- more meaning

[XuanLi-Leong]

Very small final changes and then we can merge it!

[XuanLi-Leong]

🚢 🚀 !! Thanks for the thoughtfulness and initiative 🙌