Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HackClub's banner year #1098

Closed
MatejMecka opened this issue Feb 26, 2018 · 25 comments
Closed

Update HackClub's banner year #1098

MatejMecka opened this issue Feb 26, 2018 · 25 comments

Comments

@MatejMecka
Copy link
Contributor

@itsmingjie
Copy link
Member

Duplicate #1007, #978

@zachlatta
Copy link
Member

zachlatta commented Mar 4, 2018 via email

@lachlanjc
Copy link
Member

I can’t do this at the moment, I don’t have Illustrator/other tools. Hoping to get it soon though.

Why do we need years on banners?

@zachlatta
Copy link
Member

zachlatta commented Mar 4, 2018 via email

@lachlanjc
Copy link
Member

I see. Where are these used?

@zachlatta
Copy link
Member

zachlatta commented Mar 5, 2018 via email

@CharlesIsaac
Copy link

Do we still need this?

@zachlatta
Copy link
Member

zachlatta commented Apr 18, 2018 via email

@zachlatta
Copy link
Member

zachlatta commented Apr 18, 2018 via email

@CharlesIsaac
Copy link

Do we have a template for the banner?

@zachlatta
Copy link
Member

We have the SVG linked at the top of this, not a template per-say.

@CharlesIsaac
Copy link

Do we still want this or something to match the site's new aesthetic?

@maxwofford
Copy link
Member

Thoughts on using the banner @wangannie made? Originally made for hackathons, but it'd work fine on club sites. Here are a couple screenshots:

image-2
image

@zachlatta
Copy link
Member

zachlatta commented Apr 18, 2018 via email

@lachlanjc
Copy link
Member

I like it! I might put the arm on the other side though. And it’s rather wide for mobile.

@itsmingjie
Copy link
Member

Let's get this thing done soon as we'll be welcoming new club leaders soon - don't want to leave a bad impression on our repo!

First step - taking off the 2016 flag - #1137

@lachlanjc @wangannie Any thoughts on when we can get this implemented?

@cole-rogers
Copy link
Contributor

Might it not make since just to do what social media buttons do and have the text be generated by some html/css so the year just auto updates? Im not sure if there is an actual font for that flag though.

cole-rogers added a commit that referenced this issue Oct 7, 2018
New flags fix issue  #1098.  Adds a 2018 flag and a no year flag. 

New flags also lack a weird spike the old one had.
@zachlatta
Copy link
Member

Yeah, agree. @lachlanjc, can you please take point on this?

@itsmingjie
Copy link
Member

Oh god we're in 2019 now lul

@zachlatta
Copy link
Member

zachlatta commented Jan 5, 2019 via email

@polytroper
Copy link
Contributor

@itsmingjie @zachlatta @lachlanjc we are all bannered up until 2021:

#1182

Do we need to re-add anything to README.md or elsewhere?

@itsmingjie
Copy link
Member

This has been a long-fought battle. But in the end, thanks to @polytroper & @lachlanjc's contributions of art, we won.

It's time to enjoy peace (until 2021).

@zachlatta
Copy link
Member

zachlatta commented Jan 7, 2019 via email

@maxwofford
Copy link
Member

Looks like this is handled so I'm closing

@lachlanjc
Copy link
Member

Adding this here as relevant for the future: http://npmjs.com/package/@hackclub/banner

https://hackclub.com/banner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants