Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some new icons + troll #40

Merged
merged 8 commits into from
Nov 2, 2022
Merged

Some new icons + troll #40

merged 8 commits into from
Nov 2, 2022

Conversation

cytronicoder
Copy link
Member

@sampoder I made a nice icon to top off the list - feel free to not add that one 🤣
I suggest squashing this into one commit, though, should you push it.

I'm a bit new to this so let me know if I made any errors/might improve on anything.

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
icons ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 3:36AM (UTC)

src/index.tsx Outdated Show resolved Hide resolved
@YodaLightsabr
Copy link
Contributor

Before this gets merged, I can copy these new icons over to ./docs/pages/api/icons/[color]/[glyph].js (so they're available with the API).

@cytronicoder
Copy link
Member Author

@YodaLightsabr That would be great - thanks!
I have removed the amogus at @sampoder's request 😞

Co-authored-by: Sam Poder <sam.r.poder@gmail.com>
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated
Comment on lines 1499 to 1505
fill="#FFF"
/>
<path d="M24.026 100.362c-9.894 0-17.767 7.873-17.767 17.767v74.009c0 9.894 7.873 17.767 17.767 17.767 9.894 0 17.768-7.873 17.768-17.767v-74.009c0-9.894-7.874-17.767-17.768-17.767Zm207.224 0c-9.895 0-17.768 7.873-17.768 17.767v74.009c0 9.894 7.873 17.767 17.768 17.767 9.894 0 17.767-7.873 17.767-17.767v-74.009c0-9.894-7.873-17.767-17.767-17.767ZM98.034 184.818c-9.894 0-17.768 7.873-17.768 17.768v74.008c0 9.894 7.874 17.767 17.768 17.767 9.894 0 17.767-7.873 17.767-17.767v-74.008c0-9.895-7.873-17.768-17.767-17.768Zm59.207 0c-9.895 0-17.768 7.873-17.768 17.768v74.008c0 9.894 7.873 17.767 17.768 17.767 9.894 0 17.767-7.873 17.767-17.767v-74.008c0-9.895-7.873-17.768-17.767-17.768Z" />
<path d="M78.443 7.117a2.47 2.47 0 0 0-1.197.326c-1.267.702-1.683 2.158-.98 3.428l12.517 22.611c-24.08 12.53-40.346 36.341-40.378 63.669H206.87c-.033-27.328-16.298-51.14-40.378-63.669l12.516-22.61c.704-1.27.287-2.727-.98-3.429a2.467 2.467 0 0 0-1.197-.326c-.9-.01-1.751.44-2.231 1.306l-12.68 22.855c-10.372-4.6-22.006-7.183-34.283-7.183-12.277 0-23.91 2.582-34.283 7.183L80.674 8.423a2.486 2.486 0 0 0-2.23-1.306Zm-30.038 96.292v114.85a19.113 19.113 0 0 0 19.155 19.154h120.155a19.113 19.113 0 0 0 19.155-19.155V103.41H48.405Z" />
<path
d="M91.068 54.923c-3.617 0-6.612 2.994-6.612 6.611 0 3.618 2.995 6.612 6.612 6.612 3.618 0 6.612-2.994 6.612-6.612 0-3.617-2.994-6.611-6.612-6.611Zm73.138 0c-3.618 0-6.612 2.994-6.612 6.611 0 3.618 2.994 6.612 6.612 6.612 3.617 0 6.612-2.994 6.612-6.612 0-3.617-2.995-6.611-6.612-6.611Z"
fill="#FFF"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you set fill="#FFF", it will ignore the fill="currentColor" attribute allowing you to change the color.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YodaLightsabr yeah I'm just following the conventions that previous emojis have used so let me know if any other changes are needed!

Co-authored-by: yodalightsabr <yoda@yodacode.xyz>
@cytronicoder
Copy link
Member Author

Huh

Copy link
Contributor

@reesericci reesericci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amogus icon should be added back in

@cytronicoder
Copy link
Member Author

exactly #hackamogus

src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
cytronicoder and others added 2 commits November 2, 2022 11:35
Co-authored-by: Sam Poder <sam.r.poder@gmail.com>
Co-authored-by: Sam Poder <sam.r.poder@gmail.com>
@cytronicoder
Copy link
Member Author

Oh bruh I forgot hashtags are not hashtags 🤣

Copy link
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged; thank you!

@sampoder sampoder merged commit 665bbe7 into hackclub:main Nov 2, 2022
@cytronicoder
Copy link
Member Author

cytronicoder commented Nov 2, 2022 via email

@YodaLightsabr
Copy link
Contributor

YodaLightsabr commented Nov 2, 2022

They don't seem to be on the website...

@sampoder
Copy link
Member

sampoder commented Nov 2, 2022

The website needed to be redeployed, now fixed!

@sampoder
Copy link
Member

sampoder commented Nov 2, 2022

@cytronicoder there seem to be issues with the android icon (rainbow worked perfectly). Could you take a look at it on the website?

@cytronicoder
Copy link
Member Author

Alright, will look into it

@cytronicoder cytronicoder mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants