Update Onboard grant jam #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update instructions as asked by Karmanyaah
|
@BrightTheBackpack is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
Can you please add this somewhere in there: https://github.com/hackclub/OnBoard/blob/71480c5fad8356149284f041f209eb5591df6a64/README.md?plain=1#L52-L53 TYSM for updating both of these though! |
karmanyaahm
reviewed
Feb 16, 2024
Comment on lines
84
to
+86
| - [ ] `Gerbers.zip`: This should be the file that you send off to the vendor. | ||
| - [ ] Design files (`design.json`, `design.sch`, `design.brd`, etc). Whatever format your designer outputs to should be included. | ||
| - [ ] Design files(`design.json`, `design.sch`, `design.brd`, etc) in `src` folder . Whatever format your designer outputs to should be included. | ||
| - [ ] `Schematic.pdf`: A pdf of your schematic, obtained from you're designer. |
There was a problem hiding this comment.
file name capitalization + do you think the explicitly listed out file formats in the README would be relevant here?
|
@SerenityUX can you merge this as is please. |
|
Thank you @BrightTheBackpack! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update instructions as asked by Karmanyaah
See #344