Image metadata is deprecated? #1579
Assignees
Labels
Comments
GalaxyGamingBoy
added a commit
to GalaxyGamingBoy/hc-sprig
that referenced
this issue
Apr 6, 2024
GalaxyGamingBoy
added a commit
to GalaxyGamingBoy/hc-sprig
that referenced
this issue
Apr 29, 2024
This reverts commit 6390c59.
JosiasAurel
pushed a commit
that referenced
this issue
May 22, 2024
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this issue
May 25, 2024
* fix: Remove wrong img value. re hackclub#1579 * revert formating * revert formating * revert formating revert formating revert formating * chore: Remove metadata * Revert "fix: Remove wrong img value. re hackclub#1579" This reverts commit 6390c59. --------- Co-authored-by: graham <graham@hackclub.com>
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this issue
May 25, 2024
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this issue
Jun 6, 2024
* fix: Remove wrong img value. re hackclub#1579 * revert formating * revert formating * revert formating revert formating revert formating * chore: Remove metadata * Revert "fix: Remove wrong img value. re hackclub#1579" This reverts commit 6390c59. --------- Co-authored-by: graham <graham@hackclub.com>
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this issue
Jun 6, 2024
GalaxyGamingBoy
added a commit
that referenced
this issue
Jun 10, 2024
GalaxyGamingBoy
added a commit
that referenced
this issue
Jun 10, 2024
* fix: Remove wrong img value. re #1579 * revert formating * revert formating * revert formating revert formating revert formating * chore: Remove metadata * chore: Purge Script Start * chore: remove @tag * fix: Remove dependency on @img tag * Remove single quote - Eat_&_Dont_Be_Eaten.js * Remove single quote - Orpheus_Burger_Dash.js * Remove single quote - yondus_Arrow.js * Remove () - turtle_game_reach_the_beach.js * Remove () - seven_ate_nine_789.js * Fix failing test * Update Countdown_Golf.js * Update MicroBot_Adventure.js * Update dino-game.js * Update examples.ts
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this issue
Jun 11, 2024
Cosmin-Mare
pushed a commit
that referenced
this issue
Jun 13, 2024
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this issue
Jun 14, 2024
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this issue
Jun 14, 2024
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this issue
Jun 14, 2024
Cosmin-Mare
pushed a commit
that referenced
this issue
Jun 18, 2024
recursiveforte
added a commit
that referenced
this issue
Jun 25, 2024
…instance (#1836) * fix: Remove wrong img value. re #1579 * revert formating * revert formating * revert formating revert formating revert formating * add saving strat and collab on top of existing functionality, by changing a variable in state.ts * fixed mixup between beta editor and editor * add files not added previously * removed repeated file * solve minor bugs * add yCollab extention * change db timestamp instead of calling endpoint(server also changed) * change state variable responsible for new feature to FALSE * change saveGame2 name, make feature be enabled by navigating to /~/beta/[id], remove chatty console logs, throw an error if persistence state is not passed, make the signaling server env variable, extract waitInitialUpdate to separate function, make it so if room connection couldn't be established, refresh, add comment block for start-saving endpoint, send 500 if save to db throws error, fix bug where saving strat boolean doesn't change, fix env variable usage * fix sprig editor bug caused by constantly replacing the editor --------- Co-authored-by: GalaxyGamingBoy <xrteach@gmail.com> Co-authored-by: Mare Cosmin <cosmin@hackclub.com> Co-authored-by: Cosmin-Mare <cosmintudor.mare@cnamd.onmicrosoft.com>
recursiveforte
added a commit
that referenced
this issue
Jun 25, 2024
) * fix: Remove wrong img value. re #1579 * revert formating * revert formating * revert formating revert formating revert formating * add saving strat and collab on top of existing functionality, by changing a variable in state.ts * fixed mixup between beta editor and editor * add files not added previously * removed repeated file * solve minor bugs * add yCollab extention * change db timestamp instead of calling endpoint(server also changed) * change state variable responsible for new feature to FALSE * change saveGame2 name, make feature be enabled by navigating to /~/beta/[id], remove chatty console logs, throw an error if persistence state is not passed, make the signaling server env variable, extract waitInitialUpdate to separate function, make it so if room connection couldn't be established, refresh, add comment block for start-saving endpoint, send 500 if save to db throws error, fix bug where saving strat boolean doesn't change, fix env variable usage * fix sprig editor bug caused by constantly replacing the editor * fix thing? * Update yarn.lock --------- Co-authored-by: Mare Cosmin <cosmin@hackclub.com>
recursiveforte
added a commit
that referenced
this issue
Jun 25, 2024
* fix: Remove wrong img value. re #1579 * revert formating * revert formating * revert formating revert formating revert formating * add saving strat and collab on top of existing functionality, by changing a variable in state.ts * fixed mixup between beta editor and editor * add files not added previously * removed repeated file * solve minor bugs * add yCollab extention * change db timestamp instead of calling endpoint(server also changed) * change state variable responsible for new feature to FALSE * change saveGame2 name, make feature be enabled by navigating to /~/beta/[id], remove chatty console logs, throw an error if persistence state is not passed, make the signaling server env variable, extract waitInitialUpdate to separate function, make it so if room connection couldn't be established, refresh, add comment block for start-saving endpoint, send 500 if save to db throws error, fix bug where saving strat boolean doesn't change, fix env variable usage * fix sprig editor bug caused by constantly replacing the editor * fix thing? * fix thing? * fix thing? * Update yarn.lock --------- Co-authored-by: GalaxyGamingBoy <xrteach@gmail.com> Co-authored-by: Mare Cosmin <cosmin@hackclub.com> Co-authored-by: Cosmin-Mare <cosmintudor.mare@cnamd.onmicrosoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
All games on Sprig have a few metadata properties (i.e.
@title,@author) and one of them is@img. After investigating some games that in the img property used "filename.png", I noticed the web browser make a call to/gallery/game.png. That however points to the gallery editor and the img itself. After looking more into the source code I located that the image source is now loaded via the already existing sprig API.To Reproduce
Steps to reproduce the behavior:
filename.pngExpected behavior
The game img loads normally without any errors
Actual behavior
The game img loads normally but games with the specified
@imgtag point to bad path.Solution
The solution is rather easy:
Tasks
Screenshots
If applicable, add screenshots to help explain your problem.
The text was updated successfully, but these errors were encountered: