Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge @img tag for all games #1627

Merged
merged 20 commits into from
Jun 10, 2024

Conversation

GalaxyGamingBoy
Copy link
Member

closes #1579

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 0:22am

Copy link

vercel bot commented Apr 29, 2024

@GalaxyGamingBoy is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@GalaxyGamingBoy GalaxyGamingBoy changed the title Purge @img tag for all gamse Purge @img tag for all games Apr 29, 2024
@vercel vercel bot temporarily deployed to Preview – sprig April 29, 2024 11:07 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig April 29, 2024 11:42 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig April 29, 2024 11:45 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig April 29, 2024 11:46 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig April 29, 2024 11:51 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig April 29, 2024 12:23 Inactive
@grymmy
Copy link
Contributor

grymmy commented May 1, 2024

@GalaxyGamingBoy before landing plz look at the plagiarism checker and test-game action failures

@grymmy
Copy link
Contributor

grymmy commented May 1, 2024

@JosiasAurel sorry - I tried looking at your requested changes here but the large # of files made it - for one reason or another - somewhat difficult to understand the changes you want on this diff - can u plz ELI5 for me (I am almost definitely missing something)

@GalaxyGamingBoy
Copy link
Member Author

@GalaxyGamingBoy before landing plz look at the plagiarism checker and test-game action failures

Already done w/ Josias, the plagiarism one only works on a single file and the other test failed - because of an error on one game,

@JosiasAurel
Copy link
Contributor

@JosiasAurel sorry - I tried looking at your requested changes here but the large # of files made it - for one reason or another - somewhat difficult to understand the changes you want on this diff - can u plz ELI5 for me (I am almost definitely missing something)

the majority of the files applied the changes. I wanted to make sure that removing the src property on the img tag won't break anything and it hasn't as far as i can tell

@JosiasAurel
Copy link
Contributor

please resolve conflicts and we can merge!

Copy link
Contributor

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GalaxyGamingBoy GalaxyGamingBoy merged commit 31b2bce into hackclub:main Jun 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image metadata is deprecated?
3 participants