New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the tags used on the games #1637
base: main
Are you sure you want to change the base?
Conversation
revert formating revert formating
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@GalaxyGamingBoy is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a few corrections to be made.
also please avoid formatting the code in the future it makes it hard to see the code diff
What sort of feedback are you looking for on this review? I can describe what it's supposed to do but I think reviewing the code itself for correctness is outside my purview. |
I am looking for feedback on the submission steps - see updated steps here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, if verbose (could be a smaller singular section).
Only have title and author in the the default file. The additional information should be referenced in the submission doc not the default example. |
With the results of discussion on issue #1454, the most common opinion was to educate the users on using and filling out the tags rather than abstracting them entirely making them confused more in the long run. This PR documents the process that a user would need to follow in order to fill in the tags and can be found in the sprig submit instructions (/get path)