Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the tags used on the games #1637

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

GalaxyGamingBoy
Copy link
Member

@GalaxyGamingBoy GalaxyGamingBoy commented May 1, 2024

With the results of discussion on issue #1454, the most common opinion was to educate the users on using and filling out the tags rather than abstracting them entirely making them confused more in the long run. This PR documents the process that a user would need to follow in order to fill in the tags and can be found in the sprig submit instructions (/get path)

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 5:54pm

Copy link

vercel bot commented May 1, 2024

@GalaxyGamingBoy is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few corrections to be made.
also please avoid formatting the code in the future it makes it hard to see the code diff

src/pages/get.astro Outdated Show resolved Hide resolved
src/pages/get.astro Outdated Show resolved Hide resolved
src/pages/get.astro Outdated Show resolved Hide resolved
@leomcelroy
Copy link
Collaborator

What sort of feedback are you looking for on this review? I can describe what it's supposed to do but I think reviewing the code itself for correctness is outside my purview.

@JosiasAurel
Copy link
Contributor

What sort of feedback are you looking for on this review? I can describe what it's supposed to do but I think reviewing the code itself for correctness is outside my purview.

I am looking for feedback on the submission steps - see updated steps here

Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, if verbose (could be a smaller singular section).

@leomcelroy
Copy link
Collaborator

Only have title and author in the the default file. The additional information should be referenced in the submission doc not the default example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing headers in new game files
4 participants