-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for other animated formats #67
Comments
Ah! That's not good. I never did get multi-image support complete, mostly because I do not have many such files and ImageMagick can be rather persnickety about workarounds. Would you mind uploading a sample file and describing how you'd like lsix to behave? Thanks! |
Sure. Had to zip it because GitHub didn’t like it otherwise. I expect this to behave just like it does for a gif file, where it shows the first frame as if it was a still image. Here is a screenshot exhibiting the issue: Notice how there are gif files that correctly only show a single frame, and then the (attached) webp file floods the terminal. I’m guessing there are other file extensions (apng maybe?) that should behave the same as well, but I don’t seem to have any such file. |
Thanks for the sample file. It was a simple fix: just changed "gif" to "gif|webp". |
I get two frames for webp files now though. 🤔 |
Oh. That's odd. I guess it isn't as simple of a fix as I thought. |
Oh, ho! It was a typo introduced by Github's new fancy-pants builtin code editor. I thought for such a simple change how could I go wrong? Please try it now. |
That’ll teach you to trust fancy new tech! 😉 It works, thanks! |
There is a check for gif images to only draw the first frame if no filename is given. Other animated formats such as webp fall through the cracks.
The text was updated successfully, but these errors were encountered: