Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for other animated formats #67

Closed
afranke opened this issue Nov 14, 2023 · 7 comments
Closed

Check for other animated formats #67

afranke opened this issue Nov 14, 2023 · 7 comments

Comments

@afranke
Copy link

afranke commented Nov 14, 2023

There is a check for gif images to only draw the first frame if no filename is given. Other animated formats such as webp fall through the cracks.

@hackerb9
Copy link
Owner

Ah! That's not good. I never did get multi-image support complete, mostly because I do not have many such files and ImageMagick can be rather persnickety about workarounds.

Would you mind uploading a sample file and describing how you'd like lsix to behave? Thanks!

@afranke
Copy link
Author

afranke commented Nov 15, 2023

Sure. Had to zip it because GitHub didn’t like it otherwise.

not_a_smart_man.zip

I expect this to behave just like it does for a gif file, where it shows the first frame as if it was a still image. Here is a screenshot exhibiting the issue:

image

Notice how there are gif files that correctly only show a single frame, and then the (attached) webp file floods the terminal.

I’m guessing there are other file extensions (apng maybe?) that should behave the same as well, but I don’t seem to have any such file.

@hackerb9
Copy link
Owner

Thanks for the sample file. It was a simple fix: just changed "gif" to "gif|webp".

@afranke
Copy link
Author

afranke commented Nov 15, 2023

I get two frames for webp files now though. 🤔

@hackerb9 hackerb9 reopened this Nov 15, 2023
@hackerb9
Copy link
Owner

Oh. That's odd. I guess it isn't as simple of a fix as I thought.

@hackerb9
Copy link
Owner

hackerb9 commented Nov 15, 2023

Oh, ho! It was a typo introduced by Github's new fancy-pants builtin code editor. I thought for such a simple change how could I go wrong? Please try it now.

@afranke
Copy link
Author

afranke commented Nov 15, 2023

That’ll teach you to trust fancy new tech! 😉

It works, thanks!

@afranke afranke closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants