Merge Vite branch #1647
Merged
Merge Vite branch #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add proxy to backend via .env vars * Configure output dir to be same as create-react-app
* Does not replace old start command yet
Move frontend to use Vite
chore: Add "engines" and specifcy node 18+
chore: Move Vite out of dev dependencies
asset: Update Dockerfiles in client
asset: Update node in backend as well
Cofix: Add step to specify more current node
fix: Direct call to upgrade node in action
fix: Add rest of Dockerfiles, missed two
fix: Swap to node:18.alpine, remove 'npm i- g npm'
fix: Change to alpine:3.14 in Dockerfile.prod
wip: Update containers for testing
wip: Update to node:20-alpine in Dockerfile.prod
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
evanyang1
approved these changes
May 30, 2024
|
@spiteless & @jbubar to meet on Friday at 3pm to review together |
|
Josh did it. blame him if things are broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1639
Overview
Switching off Create React App to Vite is recommended, and allows us to get a hold of security vulnerabilities and use tools like ESLint without as much of a configuration hassle. It will also let us resume using dependabot.
Merging this branch will require devs to reinstall dependencies in /client.
What changes did you make and why did you make them ?
jsxas vite requirementScreenshots of Proposed Changes Of The Website
No visual changes