Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create loading state for save button on ProjectForm.js #1650

Merged
merged 10 commits into from
Jun 25, 2024

Conversation

lcchrty
Copy link
Member

@lcchrty lcchrty commented May 31, 2024

Fixes #1574

What changes did you make and why did you make them ?

  • Added loading state
  • Conditionally rendered disabled save button based on load state
  • updated dependency arrays in ManageProjects.js to eliminate compile errors

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b lcchrty-1574-create-save-loading-state development
git pull https://github.com/lcchrty/VRMS.git 1574-create-save-loading-state

@lcchrty lcchrty requested a review from trillium May 31, 2024 14:57
Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave some notes, leme know what you think!

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thanks, this is looking good :)

@JackHaeg
Copy link
Member

@spiteless Just checking in! I noticed that this PR is still open, and it looks like it's ready to be merged. If it's ready to go, can we merge & close the issue?

@trillium trillium merged commit e557f49 into hackforla:development Jun 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create loading state for save buttons on forms related to projects
3 participants