Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add github-handle for John Darragh #7348

Merged
merged 1 commit into from
Aug 25, 2024
Merged

add github-handle for John Darragh #7348

merged 1 commit into from
Aug 25, 2024

Conversation

k-cardon
Copy link
Member

@k-cardon k-cardon commented Aug 24, 2024 •
edited
Loading

Fixes #7172

What changes did you make?

adds github-handle: beneath name: John Darragh on tdm-calculator.md (Index)

Why did you make the changes (we will use this info to test)?

technical debt, required on issue 7172

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b k-cardon-update-handle-7172 gh-pages
git pull https://github.com/k-cardon/hack4LA-website.git update-handle-7172

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 24, 2024
@FamousHero FamousHero requested review from FamousHero and removed request for FamousHero August 24, 2024 20:38
@bexux bexux self-requested a review August 25, 2024 00:14
@bexux
Copy link
Member

bexux commented Aug 25, 2024

Review ETA: 9 PM 8/24/24
Availability: 6-8 PM PST Weekdays

bexux
bexux approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@bexux bexux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The branch is correct, issue was linked, and instructions followed! Nice work.

@bexux bexux mentioned this pull request Aug 25, 2024
Open
@kgold2018 kgold2018 self-requested a review August 25, 2024 05:19
kgold2018
kgold2018 approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@kgold2018 kgold2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @k-cardon ,
Looks good.
I can see that you added the github-handle line in the right place and that the webpage's appearance is unchanged. Nice work!

@t-will-gillis t-will-gillis merged commit 1b54508 into hackforla:gh-pages Aug 25, 2024
6 of 8 checks passed
@k-cardon k-cardon mentioned this pull request Aug 25, 2024
Open
@kgold2018 kgold2018 mentioned this pull request Sep 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bexux bexux bexux approved these changes

@kgold2018 kgold2018 kgold2018 approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add github-handle for John Darragh in tdm-calculator.md
4 participants
@k-cardon @bexux @kgold2018 @t-will-gillis