Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Export PDF with puppeteer #1450

Open
wants to merge 5 commits into
base: develop
from
Open

WIP: Export PDF with puppeteer #1450

wants to merge 5 commits into from

Conversation

@Yukaii
Copy link
Member

Yukaii commented Mar 9, 2020

It takes about 5 seconds to print a pdf now... quite slow.

TODO

  • Better download experience
  • Is this safe?
  • NPM_CONFIG_PRODUCTION true
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii temporarily deployed to codimd-feature-pdf-expo-las27r Mar 9, 2020 Inactive
@Yukaii Yukaii changed the title Export PDF with puppeteer WIP: Export PDF with puppeteer Mar 9, 2020
@Yukaii Yukaii added this to the Next milestone Mar 9, 2020
@Yukaii Yukaii added the enhancement label Mar 9, 2020
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii temporarily deployed to codimd-feature-pdf-expo-las27r Mar 9, 2020 Inactive
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii temporarily deployed to codimd-feature-pdf-expo-las27r Mar 9, 2020 Inactive
@Yukaii Yukaii had a problem deploying to codimd-feature-pdf-expo-las27r Mar 9, 2020 Failure
@Yukaii Yukaii had a problem deploying to codimd-feature-pdf-expo-las27r Mar 14, 2020 Failure
@Yukaii

This comment has been minimized.

Copy link
Member Author

Yukaii commented Mar 14, 2020

Heroku image is too big when building with puppeteer buildpack

I'll try to move all webpack build dependency into devDependency, then let heroku remove them automatically.

@Yukaii

This comment has been minimized.

Copy link
Member Author

Yukaii commented Mar 14, 2020

-----> Compressing...
 !     Compiled slug size: 612.6M is too large (max is 500M).
 !     See: http://devcenter.heroku.com/articles/slug-size
 !     Push failed

https://devcenter.heroku.com/articles/slug-compiler#slug-size

Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii had a problem deploying to codimd-feature-pdf-expo-las27r Mar 19, 2020 Failure
@Yukaii Yukaii had a problem deploying to codimd-feature-pdf-expo-las27r Mar 19, 2020 Failure
@Yukaii

This comment has been minimized.

Copy link
Member Author

Yukaii commented Mar 19, 2020

-----> Compressing...
 !     Compiled slug size: 520.4M is too large (max is 500M).
 !     See: http://devcenter.heroku.com/articles/slug-size
 !     Push failed

well, well 😂

Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii

This comment has been minimized.

Copy link
Member Author

Yukaii commented Mar 19, 2020

       Procfile declares types -> web
-----> Compressing...
       Done: 493.6M
-----> Launching...
 !     Warning: Your slug size (493 MB) exceeds our soft limit (300 MB) which may affect boot time.
       Released v10
       https://codimd-feature-pdf-expo-las27r.herokuapp.com/ deployed to Heroku
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.