Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checker #10

Open
franziskuskiefer opened this issue Mar 24, 2018 · 3 comments
Open

Type checker #10

franziskuskiefer opened this issue Mar 24, 2018 · 3 comments

Comments

@franziskuskiefer
Copy link
Member

To make sure that hacspecs are properly typed we need a way to type check specs. We started out using mypy but it turns out it doesn't support everything we need without modification.
Instead of using a separate type checker the spec checker (issue #9) could also check types.

@strub
Copy link
Collaborator

strub commented Mar 26, 2018

The OCaml checker is going to come with a type-checker (it is more or less done).

We need a way to provide types for functions coming from "imports".

@franziskuskiefer
Copy link
Member Author

We need a way to provide types for functions coming from "imports".

I thought about that yesterday and I think we shouldn't allow any imports other than local files (which need to be typed) and speclib.py, which is typed as well. This means we have to extend speclib with everything useful (like wots uses math.ceil and math.log). But then this shouldn't be an issue.

@strub
Copy link
Collaborator

strub commented Mar 28, 2018

Fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants