Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to "sortby" in caprieval #153

Closed
rvhonorato opened this issue Nov 26, 2021 · 6 comments · Fixed by #182 or #185
Closed

Add option to "sortby" in caprieval #153

rvhonorato opened this issue Nov 26, 2021 · 6 comments · Fixed by #182 or #185
Assignees
Labels
enhancement Enhancing an existing feature of adding a new one

Comments

@rvhonorato
Copy link
Member

We could sort the output of caprieval by score or some of the calculated metrics.

@rvhonorato rvhonorato added the enhancement Enhancing an existing feature of adding a new one label Nov 26, 2021
@rvhonorato rvhonorato self-assigned this Nov 26, 2021
@rvhonorato rvhonorato added this to To do in Enhancements via automation Nov 26, 2021
@joaomcteixeira
Copy link
Member

Since you are refering this. I would suggest also to arrange the file not by tab separated columns but by fixed number of spaces, so that columns are always well aligned (by giving enough free spaces.

@amjjbonvin
Copy link
Member

amjjbonvin commented Nov 26, 2021 via email

@rvhonorato
Copy link
Member Author

I think that having the score there would be valuable for a few type of analysis, but this is out of scope for a module that calculates the CAPRI metrics since the score is not part of it.

What sort of analysis could be done with the capri metrics + scores? Ideally this should be a different module.

Anyway this is my opinion, we can of course add it, rule # 1 😉

@amjjbonvin
Copy link
Member

amjjbonvin commented Nov 27, 2021 via email

Enhancements automation moved this from To do to Done Dec 7, 2021
@rvhonorato rvhonorato reopened this Dec 7, 2021
Enhancements automation moved this from Done to To do Dec 7, 2021
@rvhonorato
Copy link
Member Author

Reopened since we should not use pandas as a dependency and this option needs to be re-implemented.

@rvhonorato
Copy link
Member Author

Reverted with #184

joaomcteixeira added a commit that referenced this issue Dec 7, 2021
Enhancements automation moved this from To do to Done Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one
Projects
Enhancements
  
Done
3 participants