Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to "sortby" in caprieval #182

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Add option to "sortby" in caprieval #182

merged 2 commits into from
Dec 7, 2021

Conversation

rvhonorato
Copy link
Member

I re-implemented the output function because life is better with pandas 🐼


This closes #153.

@rvhonorato rvhonorato added the enhancement Enhancing an existing feature of adding a new one label Dec 7, 2021
@rvhonorato rvhonorato self-assigned this Dec 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #182 (aee955b) into main (4680da1) will increase coverage by 0.07%.
The diff coverage is 3.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   41.09%   41.17%   +0.07%     
==========================================
  Files          41       41              
  Lines        2280     2278       -2     
==========================================
+ Hits          937      938       +1     
+ Misses       1343     1340       -3     
Impacted Files Coverage Δ
src/haddock/modules/analysis/caprieval/__init__.py 12.32% <3.89%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4680da1...aee955b. Read the comment docs.

Copy link
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice option!

@rvhonorato rvhonorato merged commit 9c564b2 into main Dec 7, 2021
@rvhonorato rvhonorato deleted the 153 branch December 7, 2021 10:51
@joaomcteixeira
Copy link
Member

I actually strongly disagree we add pandas to the requirements. It's a very heavy dependency that we need to manage on top of everything and breaks one of the features we are working hard to have in haddock3, which is having a lightweight python-shell that people can install to use haddock3's features in servers or locally without the need to install the simulation machinery while keeping everything lightweight. I would do an internal sorting function.

rvhonorato added a commit that referenced this pull request Dec 7, 2021
This reverts commit 9c564b2, reversing
changes made to 1bd79f0.
rvhonorato added a commit that referenced this pull request Dec 7, 2021
Revert "Merge pull request #182 from haddocking/153"
@rvhonorato
Copy link
Member Author

Reverted on #184 and reopened #153

@joaomcteixeira joaomcteixeira added the m|caprieval Improvements in caprieval module label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one m|caprieval Improvements in caprieval module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to "sortby" in caprieval
4 participants