-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to sort-by in caprieval
#185
Conversation
also some code linting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the default.cfg
file of the module reflect the sorting option? There must be a parameter for it.
I am reviewing the PR still |
I've added these two parameters, is that what you mean? sortby = 'score'
ascending = true |
Yes - all fine - I though I had deleted this comment :-)
|
Codecov Report
@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 41.09% 41.04% -0.06%
==========================================
Files 41 41
Lines 2280 2283 +3
==========================================
Hits 937 937
- Misses 1343 1346 +3
Continue to review full report at Codecov.
|
Cool sort implementation Rodrigo. I know it is an extra effort but very easily we removed the need for
Now it is also human-readable. Separators are spaces. If you don't have anything more to add, it is good to merge. Go for it, |
This is a remake of #182, now in pure-python implementation since we should not use
pandas
which again closes #153.