Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorizationService is not disposed #3

Open
itaybia opened this issue May 23, 2018 · 2 comments
Open

AuthorizationService is not disposed #3

itaybia opened this issue May 23, 2018 · 2 comments
Labels

Comments

@itaybia
Copy link

itaybia commented May 23, 2018

the AuthorizationService created inside AppAuthWebView should be disposed when not used anymore otherwise it creates a leak.
also, the service creates a binding to a CustomTabManager which may be problematic (and is also something you wished not to use in the first place, but use the web view instead). i think the AppAuthConfiguration should be set with a browser matcher that will always return false.

@hadiidbouk
Copy link
Owner

I am really busy at the moment, i can't edit this library soon, i will be grateful if you fix these problems and send me PR.

@ghost
Copy link

ghost commented Aug 11, 2019

For the second part I think this could work:

AppAuthConfiguration appAuthConfig = new AppAuthConfiguration.Builder()
.setBrowserMatcher(descriptor -> false)
.build();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants