Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rtools.r #298

Closed
wants to merge 1 commit into from
Closed

Update rtools.r #298

wants to merge 1 commit into from

Conversation

JoshOBrien
Copy link

With R-3.0.1 released, Rtools 3.0 is still the most current version of Rtools. Edited final element of version_info to reflect this.

With R-3.0.1 released, Rtools 3.0 is still the most current version of Rtools. Edited final element of version_info to reflect this.
@BrianDiggs
Copy link
Contributor

I wonder if it would not be better to set the version.max on the last version of Rtools to something absurdly large (such as "4.0.0"). With this approach, devtools would not need to be updated with each (minor) release of R. I think it is a choice of failure modes:

  • When a new version of R comes out, until devtools is updated and the update installed, the right Rtools can't be determined
  • When a new version of Rtools comes out, old versions of devtools which have not been updated (to a version of devtools which recognizes the new version of Rtools) will require/look for the wrong version of Rtools.

The first happens more often (but with announcements, so it can be gotten ahead of) and results in a failure mode where you can't do something; the latter happens more rarely, but will always allow something to work even if it is sometimes the wrong thing.

I'm not even sure which one I would advocate.

@hadley
Copy link
Member

hadley commented May 17, 2013

@jjallaire any thoughts? What do you do for RStudio?

@BrianDiggs
Copy link
Contributor

Looking at the rough patterns some more, setting the max to "3.0.99" might be the sweet spot of covering everything likely to be appropriate and likely not including too much that isn't. In general, if the most recent version is "a.b", set the max to "a.b.99", to be adjusted when there is a real max (which would presumably be known when a new Rtools comes out).

@jjallaire
Copy link
Collaborator

In RStudio we do a slightly less conservative version of this so that we can work with R-devel. Currently we treat Rtools 3.0 as compatible with a max R version of 3.1

On May 17, 2013, at 6:05 PM, Brian Diggs notifications@github.com wrote:

Looking at the rough patterns some more, setting the max to "3.0.99" might be the sweet spot of covering everything likely to be appropriate and likely not including too much that isn't. In general, if the most recent version is "a.b", set the max to "a.b.99", to be adjusted when there is a real max (which would presumably be known when a new Rtools comes out).


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants