Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - improve code quality - remove Static Variables #1

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

khardikk
Copy link
Owner

@khardikk khardikk commented Aug 9, 2023

Your checklist for this pull request

  • [ x] I've read the guidelines for contributing to this repository
  • [ x] I made sure to follow the project's coding style
  • [ x] I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This PR addresses the issue of removing static variables from the RzAsm and RzAnalysis plugins to improve code readability and maintainability, It is for the asm_sysz.c file. The changes follow the guidelines outlined in the contribution and the Developers guide.
...

Test plan

...

Closing issues

...

This PR addresses the issue of removing static variables from the RzAsm and RzAnalysis plugins to improve code readability and maintainability, It is for the asm_sysz.c file.
The changes follow the guidelines outlined in the contribution and the Developers guide.
@khardikk khardikk changed the title ##refactor - improve code quality - remove Static Variables refactor - improve code quality - remove Static Variables Aug 9, 2023
Refactor the disassemble() function to introduce a context structure that encapsulates the `omode` value of that code is cached between different disassemble() function calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant