Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

test/helper should be replaced with openzeppelin-test-helpers #78

Closed
leekt opened this issue Jan 26, 2019 · 1 comment
Closed

test/helper should be replaced with openzeppelin-test-helpers #78

leekt opened this issue Jan 26, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request utils About vvisp-utils
Milestone

Comments

@leekt
Copy link
Contributor

leekt commented Jan 26, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

currently, vvisp init generates test/helpers folder which is from older version of openzeppelin
since openzeppelin-test-helper module is very useful and has more features, it would be better for vvisp to use this.

Expected behavior

package.json includes "openzeppelin-test-helpers"
no more test/helpers
since just adding this will produce a lot of errors,
truffle has to be upgraded to version 5 or up

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


vvisp version: X.Y.Z


Environment:
- Node version:
- Operating system:

Others:

@JhChoy JhChoy added enhancement New feature or request utils About vvisp-utils labels Jan 28, 2019
@JhChoy JhChoy added this to the vvisp v1.0.0 milestone Feb 28, 2019
@JhChoy
Copy link
Contributor

JhChoy commented Feb 28, 2019

It was closed with #85

@JhChoy JhChoy closed this as completed Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request utils About vvisp-utils
Projects
None yet
Development

No branches or pull requests

3 participants