Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IonSim structs #96

Closed
marwahaha opened this issue Jul 19, 2022 · 0 comments · Fixed by #97
Closed

Rename IonSim structs #96

marwahaha opened this issue Jul 19, 2022 · 0 comments · Fixed by #97
Labels
needs-brainstorm Further information is requested

Comments

@marwahaha
Copy link
Member

marwahaha commented Jul 19, 2022

see also #73

There was a discussion about renaming the structs involved. Currently, this is how it works:

  • Ion (responsible for the parameters of each ion involved)
  • IonConfiguration (responsible for how the ions are stuck together)
  • Trap (the entire apparatus!)

If we add multi-species chains and other tools, the proposal was to rename the structs to reflect what they ``actually'' do.

KM suggested:

  • IonConfiguration -> IonTrap
  • Trap -> Chamber
@marwahaha marwahaha changed the title rename IonConfiguration and Trap? rename IonConfiguration Sep 21, 2022
@marwahaha marwahaha changed the title rename IonConfiguration rename objects Sep 21, 2022
@marwahaha marwahaha changed the title rename objects rename IonSim structs Sep 21, 2022
@marwahaha marwahaha changed the title rename IonSim structs Rename IonSim structs Sep 21, 2022
@marwahaha marwahaha added the needs-brainstorm Further information is requested label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-brainstorm Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant