Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding f# 4.1 Error handling via Result #16

Merged
merged 3 commits into from
Nov 27, 2017
Merged

Adding f# 4.1 Error handling via Result #16

merged 3 commits into from
Nov 27, 2017

Conversation

wallymathieu
Copy link
Contributor

  • Moved main Choice<,> error handling to Compatibility modules
  • Copy and modify of Choice<,> error handling but with Result<,>

@wallymathieu
Copy link
Contributor Author

Thoughts @haf ?

@haf
Copy link
Owner

haf commented Nov 23, 2017

I don't think we need to break the API just to support Result. But I like supporting result.

@wallymathieu
Copy link
Contributor Author

Perhaps creating a YoloResults.fs file? So that you can choose what kind of behavior you want?

@haf
Copy link
Owner

haf commented Nov 23, 2017

YoLo moves with f#, so if F# supports Result we can add it.

@wallymathieu
Copy link
Contributor Author

So does this look more OK? Basically only adding the Result things and keeping everything else as is.

@haf haf merged commit d9778b7 into haf:master Nov 27, 2017
@haf
Copy link
Owner

haf commented Nov 27, 2017

Thanks!

@wallymathieu
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants