fix: Dependency Requiring CGO #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh thank you! I guess this will fix #64. Not sure why CI isn't kicking off... 🤔 |
hairyhenderson
approved these changes
Apr 19, 2022
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Some CI fixes
|
@hairyhenderson - I have rebased, but it seems like I need a maintainer to approve running workflows |
|
Looks like the rebase didn't work quite right - there shouldn't need to be a merge commit in there... Alternately, can you enable the
|
|
(in the meantime, I have approved the workflows - CI's running now, which is progress! 😉) |
commit afb9d05 Merge: 37e50d6 7b6420d Author: Dave Henderson <dhenderson@gmail.com> Date: Tue Apr 19 13:21:07 2022 -0400 Merge pull request hairyhenderson#70 from hairyhenderson/dependabot/github_actions/actions/checkout-3 Bump actions/checkout from 2 to 3 commit 7b6420d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Apr 19 16:28:20 2022 +0000 Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
@bbernays I'm still seeing commits that shouldn't be here... Can you do: $ git fetch upstream
$ git rebase upstream/main
$ git push -f |
|
I am closing this pr, because I opened a new clean PR |
|
ok - this one was salvageable if you'd done a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched from
Azure/azure-storage-blob-go/azblobtoAzure/azure-sdk-for-go/sdk/storage/azblobfor the azblob asazure-storage-blob-gohas been deprecated.Used the unreleased version
gocloud.devpackage: