internal/gamepad: bug fix: memory leak on Xbox

Updates #2084
hajimehoshi · Jul 15, 2022 · 520a30f · 520a30f
1 parent c14403f
commit 520a30f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/internal/gamepad/api_xbox_windows.go b/internal/gamepad/api_xbox_windows.go
@@ -246,3 +246,7 @@ func (i *_IGameInputReading) GetGamepadState() (_GameInputGamepadState, bool) {
 	r, _, _ := syscall.Syscall(i.vtbl.GetGamepadState, 2, uintptr(unsafe.Pointer(i)), uintptr(unsafe.Pointer(&state)), 0)
 	return state, int32(r) != 0
 }
+
+func (i *_IGameInputReading) Release() {
+	syscall.Syscall(i.vtbl.Release, 1, uintptr(unsafe.Pointer(i)), 0, 0)
+}
diff --git a/internal/gamepad/gamepad_xbox_windows.go b/internal/gamepad/gamepad_xbox_windows.go
@@ -131,6 +131,7 @@ func (n *nativeGamepadXbox) update(gamepads *gamepads) error {
 	if err != nil {
 		return err
 	}
+	defer r.Release()
 
 	state, ok := r.GetGamepadState()
 	if !ok {