Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/ebitenmobile: embed and modify gomobile to reduce dependencies #2748

Closed
2 of 10 tasks
hajimehoshi opened this issue Sep 6, 2023 · 2 comments
Closed
2 of 10 tasks

cmd/ebitenmobile: embed and modify gomobile to reduce dependencies #2748

hajimehoshi opened this issue Sep 6, 2023 · 2 comments
Labels
breaking-change os:android os:ios refactoring
Milestone
v2.7.0

Comments

@hajimehoshi
Copy link
Owner

Operating System

  • Windows
  • macOS
  • Linux
  • FreeBSD
  • OpenBSD
  • Android
  • iOS
  • Nintendo Switch
  • Xbox
  • Web Browsers

What feature would you like to be added?

Like what we did for GLFW, we can clone the gomobile code into this repository and modify it. Now gomobile has dependencies on golang.org/x/exp/shiny, but this is not necessary for Ebitengine.

The cons is that we would have to pay costs to sync the original gomobile and the cloned gomobile.

Why is this needed?

The less dependencies, the happier we are. Especially, golang.org/x/exp and golang.org/x/exp/shiny caused some troubles (golang/go#62458).
@hajimehoshi hajimehoshi added this to the v2.7.0 milestone Sep 6, 2023
@hajimehoshi
Copy link
Owner Author

Another motivation is #2741

hajimehoshi added a commit that referenced this issue Feb 18, 2024
@hajimehoshi
all: use github.com/ebitengine/gomobile instead of golang.org/x/mobile
76a6a5c 
Closes #2748
hajimehoshi added a commit that referenced this issue Feb 18, 2024
@hajimehoshi
all: use github.com/ebitengine/gomobile instead of golang.org/x/mobile
5643b34 
Closes #2748
hajimehoshi added a commit that referenced this issue Feb 18, 2024
@hajimehoshi
all: use github.com/ebitengine/gomobile instead of golang.org/x/mobile
0ac350e 
Closes #2748
hajimehoshi added a commit that referenced this issue Feb 18, 2024
@hajimehoshi
all: use github.com/ebitengine/gomobile instead of golang.org/x/mobile
8b7cba9 
Closes #2748
hajimehoshi added a commit that referenced this issue Feb 18, 2024
@hajimehoshi
all: use github.com/ebitengine/gomobile instead of golang.org/x/mobile
1a58324 
Closes #2748
hajimehoshi added a commit that referenced this issue Feb 20, 2024
@hajimehoshi
all: use github.com/ebitengine/gomobile instead of golang.org/x/mobile
4271306 
Closes #2748
hajimehoshi added a commit that referenced this issue Feb 23, 2024
@hajimehoshi
all: use github.com/ebitengine/gomobile instead of golang.org/x/mobile
f6c7157 
Closes #2748
hajimehoshi added a commit that referenced this issue Feb 23, 2024
@hajimehoshi
all: use github.com/ebitengine/gomobile instead of golang.org/x/mobile
6c0135b 
Closes #2748
hajimehoshi added a commit that referenced this issue Feb 23, 2024
@hajimehoshi
all: use github.com/ebitengine/gomobile instead of golang.org/x/mobile
e1aa936 
Closes #2748
@hajimehoshi
Copy link
Owner Author

This is a sligh breaking change as users have to use Ebitengine's RunOnJVM for Android if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change os:android os:ios refactoring
Projects
None yet
Milestone
v2.7.0
Development

No branches or pull requests
1 participant
@hajimehoshi