Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker 26+ does not allow .git/ to be copied onto the image #1495

Closed
jacobwod opened this issue Apr 9, 2024 · 1 comment
Closed

Docker 26+ does not allow .git/ to be copied onto the image #1495

jacobwod opened this issue Apr 9, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@jacobwod
Copy link
Member

jacobwod commented Apr 9, 2024

It seems as recent Docker version requires us to change the way we build our images. I get this message, across both macOS and Linux:

Skärmavbild 2024-04-09 kl  10 48 58

I confirmed this did not happen (in our repo) on Docker < 26.0.0.


Here's a similar problem someone else is facing: https://stackoverflow.com/questions/66680559/docker-unable-to-copy-git-folder.

The proper way to solve this could be saving the Hajk version number and most recent commit hash into a file, rather than parsing it on-the-flight, as we currently do in https://github.com/hajkmap/Hajk/blob/49f36f5099cc8914c2947c1eb21e6f3011d35de0/apps/client/prebuild.js.

But that's for the Docker build. Ideally, we must find a solution that works for usual npm run build too. Ideas @hajkmap/dev?

@jacobwod jacobwod added the bug label Apr 9, 2024
@jacobwod jacobwod added this to the 3.x milestone Apr 9, 2024
@jacobwod
Copy link
Member Author

jacobwod commented Apr 9, 2024

Looks like it can be solved by properly pointing to the directory (using trailing slash).

Skärmavbild 2024-04-09 kl  11 01 43

@jacobwod jacobwod modified the milestones: 3.x, 3.14 Apr 9, 2024
@jacobwod jacobwod self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant