-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/1258 extend feature info support #1262
Conversation
I.e. using same logic as the new infoClick
…ature-info-support
Looks good, but I'll check it out in detail and do the full review before the day is over! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems over here, works as intended. Good idea to refactor the helper to utils/.
…ature-info-support
…ature-info-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested a hand full of infoclicks and it worked fine. Hard to test them all. Good work!
…ature-info-support
Should take care of #1258
Please test both the new and old infoClick with your local configurations. I've tested it with several layers without problems, but i've probably missed something.
Decided to target develop, it's a bit sketchy to put it in for 3.11 at this stage.
Henrik