Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1258 extend feature info support #1262

Merged
merged 8 commits into from
Jan 19, 2023

Conversation

Hallbergs
Copy link
Member

@Hallbergs Hallbergs commented Jan 9, 2023

Should take care of #1258

Please test both the new and old infoClick with your local configurations. I've tested it with several layers without problems, but i've probably missed something.

Decided to target develop, it's a bit sketchy to put it in for 3.11 at this stage.

Henrik

@Hallbergs Hallbergs linked an issue Jan 9, 2023 that may be closed by this pull request
@jacobwod
Copy link
Member

jacobwod commented Jan 9, 2023

Looks good, but I'll check it out in detail and do the full review before the day is over!

Copy link
Member

@jacobwod jacobwod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems over here, works as intended. Good idea to refactor the helper to utils/.

Copy link
Contributor

@jesade-vbg jesade-vbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested a hand full of infoclicks and it worked fine. Hard to test them all. Good work!

@Hallbergs Hallbergs merged commit ad5aef0 into develop Jan 19, 2023
@Hallbergs Hallbergs deleted the fix/1258-extend-feature-info-support branch January 19, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend InfoClick support
3 participants