Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend InfoClick support #1258

Closed
Hallbergs opened this issue Dec 22, 2022 · 1 comment · Fixed by #1262
Closed

Extend InfoClick support #1258

Hallbergs opened this issue Dec 22, 2022 · 1 comment · Fixed by #1262
Assignees
Labels
bug needs testing in rc Indicates extensive and potentially breaking changes that will need an extra attention during RC.
Milestone

Comments

@Hallbergs
Copy link
Member

While i was updating the config for our demo environments i found that some WMS providers returns strange responses from getFeatureInfo. See image below for an example:

image

These responses are not rendered correctly in the FeatureInfo-window since we expect the id to be constructed as
<layerName>.<some-numeric> when we try to grab the necessary information for the FeatureInfo-window from config. In the case above, another random numeric is added to the id...

I am gonna try to sort this out, and hopefully this fix can be added to the 3.11 release. I'm a bit afraid it can't be added though, since it will probably be quite big changes since the logic around the FeatureInfo is...
image

@Hallbergs Hallbergs added the bug label Dec 22, 2022
@Hallbergs Hallbergs added this to the 3.x milestone Dec 22, 2022
@Hallbergs Hallbergs self-assigned this Dec 22, 2022
@jacobwod
Copy link
Member

Great initiative with fixing the config and fantastic upcoming solution.

Let's see what it feels like after the Hollidays: whether we go for a quick merge to upcoming release or take some time to untangle this spaghetti.

@jacobwod jacobwod added the needs testing in rc Indicates extensive and potentially breaking changes that will need an extra attention during RC. label Jan 5, 2023
@Hallbergs Hallbergs linked a pull request Jan 9, 2023 that will close this issue
@Hallbergs Hallbergs modified the milestones: 3.x, 3.12 Apr 25, 2023
@jacobwod jacobwod closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs testing in rc Indicates extensive and potentially breaking changes that will need an extra attention during RC.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants