Reinstated cacheBuster to new-client #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwod
reviewed
Apr 14, 2023
new-client/src/utils/FetchWrapper.js
Outdated
Comment on lines
62
to
69
| getMetaValue(key) { | ||
| const el = document.getElementsByName(key); | ||
| if (el && el[0]) { | ||
| return el[0]?.attributes?.content?.value; | ||
| } | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this really necessary, wouldn't something like this be more sufficient and work on all modern browsers anyway?
document.querySelector("meta[name='hajk-client-use-cache-buster']").getAttribute("content");That oneliner on line 43 would be enough.
jacobwod
reviewed
Apr 14, 2023
new-client/src/utils/FetchWrapper.js
Outdated
| //this.useCacheBuster = process?.env?.REACT_APP_USE_CACHE_BUSTER === "true" || false; | ||
| this.useCacheBuster = false; | ||
| // Lets get the values from generated meta-tags | ||
| this.hash = this.getMetaValue("hajk-client-git-hash") || ""; |
There was a problem hiding this comment.
Can we be sure that the meta tag will always be called hajk-client-use-cache-buster? I mean, it's created during build time by parsing %REACT_APP_NAME%-use-cache-buster, so another value on REACT_APP_NAME will break this completely.
|
You're absolutely right regarding these 😂 I should never make PR:s on Friday afternoons 😂 I'll fix on Monday. |
|
Now it's corrected. Thanx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1323