Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hfetch - reinstate the cacheBuster functionality. #1323

Closed
jesade-vbg opened this issue Apr 14, 2023 · 0 comments · Fixed by #1324
Closed

hfetch - reinstate the cacheBuster functionality. #1323

jesade-vbg opened this issue Apr 14, 2023 · 0 comments · Fixed by #1324
Assignees
Milestone

Comments

@jesade-vbg
Copy link
Contributor

The cacheBuster fuctionality was disabled little over a year ago because we updated to webpack 5 which does not have support for process.env.

The cacheBuster fuctionality in hfetch should be reinstated again.... somehow.... with or without process.env.

Today, the code is just commented, and forgotten.

this.useCacheBuster = process?.env?.REACT_APP_USE_CACHE_BUSTER === "true" || false;

@jesade-vbg jesade-vbg added the bug label Apr 14, 2023
@jesade-vbg jesade-vbg added this to the 3.x milestone Apr 14, 2023
@jesade-vbg jesade-vbg removed the bug label Apr 14, 2023
@jesade-vbg jesade-vbg self-assigned this Apr 14, 2023
@jesade-vbg jesade-vbg linked a pull request Apr 14, 2023 that will close this issue
@jesade-vbg jesade-vbg modified the milestones: 3.x, 3.12 Apr 17, 2023
@jacobwod jacobwod closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants