Support relative URLs #1400
Merged
Support relative URLs #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Link to issue hajkmap#1309 (API version separation)
Hallbergs
approved these changes
Sep 12, 2023
|
@Hallbergs I have tested with relative URL:s in two environments using different "base" URL:s, so with your absolute URL testing this gives a solid test coverage. The upside of this patch/PR is a fully portable Hajk config where layers+map config JSON can be copy/pasted between stage or acceptance testing and production environments. I suppose it also simplifies in some container scenarios for Docker et.al. Thanks for review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realizes #1396 / resolves #1399.
Tested with: