Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for relative URLs #1399

Closed
sweco-semara opened this issue Sep 8, 2023 Discussed in #1396 · 0 comments
Closed

Support for relative URLs #1399

sweco-semara opened this issue Sep 8, 2023 Discussed in #1396 · 0 comments
Assignees
@sweco-semara
Labels
module:client/core Core functionality (not a plugin) plugin:layerswitcher Functionality and features of the LayerSwitcher plugin plugin:print
Milestone
3.13

Comments

@sweco-semara
Copy link
Contributor

sweco-semara commented Sep 8, 2023 •
edited
Loading

Make Hajk fully support relative URL:s as discussed in #1396.

Identified spots in Hajk develop around v3.12 that need attention for implementing this:

  1. Layerswitcher's GetLegendGraphic functionality. ConfigMapper.js, mapWMSConfig inner function getLegendUrl - protocol handling currently does not support relative URL:s. If using relative links for WMS URL, e.g. layers.json WMS config "url": "/geoserver/wms" will result in invalid links being constructed for getting the legend image - https://geoserver/wms?
  2. PrintMode's printing functionality. PrintModel.js, prepareImageLayer, setImageLoadFunction function call on the layer source sets a function that cannot execute with a relative URL because of the new URL(src); call. This will result in an exception, only visible in the console - the printing stops without user notice (spinner continues forever).
@sweco-semara sweco-semara added plugin:layerswitcher Functionality and features of the LayerSwitcher plugin plugin:print labels Sep 8, 2023
@sweco-semara sweco-semara mentioned this issue Sep 9, 2023
Merged
Hallbergs pushed a commit that referenced this issue Sep 12, 2023
@sweco-semara
Support relative URLs (#1400)
36542d6 
* Fix doc typo

* Link to issue #1309 (API version separation)

* Support relative links for legend URL:s

See #1399

* Let printing plug-in support relative URL:s

* Part of #1399
@Hallbergs Hallbergs added this to the 3.13 milestone Sep 13, 2023
@Hallbergs Hallbergs added the module:client/core Core functionality (not a plugin) label Sep 13, 2023
@sweco-semara sweco-semara self-assigned this Mar 14, 2024
@github-project-automation github-project-automation bot moved this to Done in Hajk Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sweco-semara sweco-semara

Labels
module:client/core Core functionality (not a plugin) plugin:layerswitcher Functionality and features of the LayerSwitcher plugin plugin:print
Projects
Hajk
Status: Done
Milestone
3.13
Development

No branches or pull requests
3 participants
@jacobwod @sweco-semara @Hallbergs