Skip to content
This repository has been archived by the owner on Dec 24, 2018. It is now read-only.

Error doesn't occur when npm installing was failed #38

Closed
anseki opened this issue Feb 8, 2015 · 2 comments
Closed

Error doesn't occur when npm installing was failed #38

anseki opened this issue Feb 8, 2015 · 2 comments

Comments

@anseki
Copy link
Contributor

anseki commented Feb 8, 2015

The npm installing was failed (network problem, maybe), but any error doesn't occur, and a version without npm was set to using.
I think that an error should occur, but this behavior has some reason?

https://github.com/hakobera/nvmw/blob/master/nvmw.bat#L154

  if not exist %NPM_ZIP_FILE% (
    exit /b 0;
  )
  if not exist "%NPM_ZIP_FILE%" goto install_error

(And, I think that that path should be quoted.)

@hakobera
Copy link
Owner

@anseki There are no reason to that behavior. It's my mistake.
This issue is solved by #39? (Yes, it's your pull request)

@anseki
Copy link
Contributor Author

anseki commented Feb 10, 2015

Yes, This issue is solved. 😄 Thank you!

@anseki anseki closed this as completed Feb 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants