Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 player challenges can still play 2 player games #438

Closed
Janzert opened this issue Jan 15, 2018 · 4 comments
Closed

4 player challenges can still play 2 player games #438

Janzert opened this issue Jan 15, 2018 · 4 comments

Comments

@Janzert
Copy link
Contributor

Janzert commented Jan 15, 2018

See challenge 1174 for an example.
http://api.halite.io/v1/api/challenge/1174
http://api.halite.io/v1/api/challenge/1174/match

Most of the games are played only between the issuer and tscommander-ml.

In this case I believe it is because tsadmiral and tscaptain have is_gpu_enabled turned on. So they only play if the challenge happens to be selected to play on a gpu enabled server.

I believe it's also the case that if one of the challenged bots had a failed upload or was otherwise disabled the remaining two challenged bots would continue playing 2 player games against the issuer.

@julskast
Copy link
Contributor

@lidavidm I thought we paused the whole challenge if any player's bot was disabled?

@lidavidm
Copy link
Contributor

lidavidm commented Jan 15, 2018

If the initiator's bot is disabled, yes, otherwise it will keep trying to play games. I guess we should probably make sure all bots are at least able to play a match before we issue one.

@julskast
Copy link
Contributor

yes @lidavidm I think that makes more sense

@harikmenon
Copy link
Contributor

Closing issue since competition is ended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants