Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal component subcommands are confusing #40

Closed
iocanel opened this issue Sep 20, 2019 · 11 comments
Closed

hal component subcommands are confusing #40

iocanel opened this issue Sep 20, 2019 · 11 comments
Labels
doc enhancement New feature or request

Comments

@iocanel
Copy link
Contributor

iocanel commented Sep 20, 2019

Going through the demo I see

hal component spring-boot and hal component create which is confusing.

As both pretty much imply skafolding. The latter should be deploy` or something.

@metacosm
Copy link
Contributor

Going through the demo I see

hal component spring-boot and hal component create which is confusing.

As both pretty much imply skafolding. The latter should be deploy or something.

That's not quite true but I understand the confusion. create doesn't scaffold anything, it actually creates the CR and lets the operator know about it. spring-boot should probably be renamed scaffold at some point, if/when we actually can scaffold something other than Spring Boot apps… :)

@cmoulliard cmoulliard added doc enhancement New feature or request labels Sep 30, 2019
@geoand
Copy link
Collaborator

geoand commented Oct 1, 2019

So is there currently an alternative to hal component spring-boot, like hal component throrntail or something?

@geoand
Copy link
Collaborator

geoand commented Oct 2, 2019

Perhaps it could be hal new-component spring-boot ?

@metacosm
Copy link
Contributor

metacosm commented Oct 4, 2019

Perhaps it could be hal new-component spring-boot ?

If I can help it, no! 😁
I'm thinking that this will go away with the new create command, where we could select scaffolding if available at the end of the create process.

@metacosm
Copy link
Contributor

metacosm commented Oct 4, 2019

So is there currently an alternative to hal component spring-boot, like hal component throrntail or something?

Ideally, there should be, yes.

@metacosm
Copy link
Contributor

metacosm commented Oct 4, 2019

Perhaps it could be hal new-component spring-boot ?

If I can help it, no! 😁
I'm thinking that this will go away with the new create command, where we could select scaffolding if available at the end of the create process.

Speaking of which, has anyone tried the new version? #32

@iocanel
Copy link
Contributor Author

iocanel commented Oct 11, 2019

Perhaps it could be hal new-component spring-boot ?

Since, we have hal component push I feel that its mandatory to go with hal component create.

@iocanel
Copy link
Contributor Author

iocanel commented Oct 11, 2019

Perhaps it could be hal new-component spring-boot ?

Since, we have hal component push I feel that its mandatory to go with hal component create.

Damn, create is already used!

Maybe new or rename create to deploy which might be too much.

@metacosm
Copy link
Contributor

The new hal component create does both operations at once if you want (and the runtime allows it) i.e. it will create a component definition and scaffold the project if you tell it to.

@iocanel
Copy link
Contributor Author

iocanel commented Oct 11, 2019

After a long discussion I had with @metacosm on zulip I'd like to share some thoughts.

Scaffolding should have it own command. Something like hal component scaffold would be the most descriptive. The command could work interactively or using arguments and allow us to scaffold projects like we do now.

Then' hal component create would have a narrower scope and it would be easier to explain what it does.

Some technical concerns around this suggestion, is that we will have to ask the user twice about the runtime, which is bad ux.

To overcome this issue, we could save information like the runtime, the version etc in a .hal file, that wil be created when we scaffold.

An alternative would be to implement a mechanism to detect the target runtime, using parsing of known project models (maven, gradle, npm).

@metacosm
Copy link
Contributor

Opened a new issue for this: #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants